Provide access to left-over milliseconds#90
Closed
jamesmyatt wants to merge 4 commits into
Closed
Conversation
Author
|
Replaced with #93, which has a different "from" branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some minimal changes to provide access to the left-over millis from a call to
now(). I know there's been lots of discussion about this, but I need it for my clock animations and I've included suitable warnings in the Readme.I think this is better than the solutions in #11 and #45, since it will be consistent with the seconds output.
Datatype for the
sysTimeMilliswas selected to matchprevMillis, which is uint32_t, rather thanmillis(), which isunsigned long.