Added a new signature for makeTime to create time_t from discrete elements#131
Open
Daemach wants to merge 2 commits into
Open
Added a new signature for makeTime to create time_t from discrete elements#131Daemach wants to merge 2 commits into
Daemach wants to merge 2 commits into
Conversation
- Creates time_t from discrete elements rather than struct
|
@Daemach thanks a lot for this code - it helped me a lot when I was implementing a feature that calculated how much time is left between now and future events on the same day: https://github.com/Bougakov/wallclock/blob/master/wallclock.ino |
|
I did the exact same thing for that purpose. But in my code. So I highly support this request 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like this library. I needed to be able to create a time_t from discrete elements so this signature creates the tm struct to pass to the original.