fix: create DN based on fulfilment#62
Open
bhattdevarsh wants to merge 5 commits into
Open
Conversation
bhattdevarsh
commented
Feb 20, 2024
bhattdevarsh
commented
- SO.make_delivery_note will skip the Item mapping
- We Iterate through the fulfilment line Items and cross check with SO, pick up only items which are actually fulfilled.
Author
|
@Alchez Needs review. |
Contributor
|
@bhattdevarsh, this works for both full and partial fulfilled orders? Do you have example local order(s) you can share a screenshot of? |
Author
Alchez
suggested changes
Feb 22, 2024
Alchez
suggested changes
Feb 23, 2024
Alchez
left a comment
Alchez
left a comment
Contributor
There was a problem hiding this comment.
Looks good, adding a minor type request
Co-authored-by: Rohan <Alchez@users.noreply.github.com>
Alchez
suggested changes
Feb 26, 2024
Alchez
suggested changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.