security: disable code execution by default in shipped config#688
Open
wtfashwin wants to merge 1 commit into
Open
security: disable code execution by default in shipped config#688wtfashwin wants to merge 1 commit into
wtfashwin wants to merge 1 commit into
Conversation
Flip turn_on_code_execution from true to false in configs/config.yaml so fresh installs do not allow remote Python execution by default. Users who want code execution can still opt in by editing their local config. Closes ParisNeo#675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configs/config.yamlships withturn_on_code_execution: true, which means a fresh install allows remote Python execution out of the box.falseso code execution is opt-in. Users who want it can still enable it in their own config.Follows the same secure-by-default direction as the recent
/api/proxyhardening (#685).Closes #675.
Test plan