Repository navigation
build: fix Clang MPI TAU configurations - #31
Merged
Merged
Conversation
- GitHub rotated its CLI apt key; `2C61...6059` expired 2026-09-04 and the repo `InRelease` is now signed by `7F38...3325` - The old pin still passed only because GitHub ships both keys in the keyring file; it would break once the old key is dropped - Fingerprints match `cli/cli` `docs/install_linux.md`
Fixes #30. - Debian's `mpifort -show` emits gfortran compile flags; TAU copies them into `TAU_MPI_FLIB`, and `clang++` rejects `-fallow-invalid-boz` when linking `libTAUsh-*.so`. `make install` stops before installing `libTauPthreadWrap.a`, so `tau_cc.sh` links fail. Strip the flags in TAU's `configure`; `flang` rejects the three hardening flags too - Point MPICH wrappers at Clang for the Clang MPI build, so TAU records `clang`/`clang++` rather than `gcc`/`g++` as `FULL_CC` and `FULL_CXX` - `installtau` exits 0 when a configuration fails, so check that each configuration installed its pthread wrapper - Broken since the switch to MPICH in `785f806` (v1.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30. The Clang MPI TAU configurations
(
clang-mpi-pthread-pdt,depthlimit-clang-mpi-pthread-pdt,param-clang-mpi-pthread-pdt) did not install completely. They havebeen broken since the switch to MPICH in
785f806(v1.4.0), so1.4, 1.5, 1.6, and 1.7 are all affected. 1.3 (Open MPI) is not.
Also pins the new GitHub CLI apt signing key.
Cause
mpifort -showadds gfortran compile flags(
-fallow-invalid-boz,-fstack-protector-strong,-fstack-clash-protection,-fcf-protection).configurecopies them intoTAU_MPI_FLIB.clang++rejects-fallow-invalid-bozwhen it linkslibTAUsh-*.so, somake installstops before it installslibTauPthreadWrap.a.flangalso rejects the three hardening flags whentau_f90.shlinks.
installtauexits 0 whenmake installfails, so the image builddid not fail.
FULL_CC/FULL_CXXfrommpicc -show, so the Clang MPIconfigurations compiled user code with
gcc/g++.Changes
Dockerfile: strip the four flags in TAU'sconfigurebeforeinstalltau. Agrep -qfails the build if TAU changes that line.Dockerfile: run the Clang MPIinstalltauwithMPICH_CC=clang MPICH_CXX=clang++ MPICH_FC=flang.Dockerfile: fail the build if anyMakefile.tau-*has nostatic-*/libTauPthreadWrap.a.Dockerfile.devtools: pin7F38BBB59D064DBCB3D84D725612B36462313325.GitHub rotated keys;
2C61...6059expired 2026-09-04, and the aptrepo
InReleaseis now signed by the new key. Both fingerprints arelisted in
cli/clidocs/install_linux.md.Testing
In a
ghcr.io/paratoolsinc/salt-dev:1.7container, with TAUmasterat
2e647c6, I ran the Clang MPIinstalltauwith the patch:libTauPthreadWrap.a.tau_cc.sh(C) andtau_f90.sh(Fortran with
mpif.h) build an MPI hello program withclang/flang. Each program runs on 2 ranks and writes 2 profiles.Makefile, builds and runs C and Fortran (
use mpi) programs.lint.shchecks pass (hadolint v2.14.0, as in CI), andtest-build-llvm.shpasses.I did not do a full image build. CI builds the image.
Not fixed
use mpiwithflang: Debian'smpi.modis in gfortran format.