Repository navigation
ci: build devtools on schedule and tag events - #28
Merged
Merged
Conversation
- `changes` is skipped on schedule and tag events. `build-devtools` lacked `always()`, so that skip propagated through `build-base` and `salt-dev-tools` was never built or pushed for tags (`v1.6.0`, `v1.7.0`) or weekly scheduled runs. - Gate on `always()` plus `needs.build-base.result == 'success'`, matching how `build-base` opts out of the skipped `changes` job.
- `build-base` tags branch images via `docker/metadata-action`, which turns `/` into `-`. The devtools `BASE_TAG` used the raw branch name, so branches like `fix/foo` failed with `invalid reference format`. - Apply the same `/` to `-` replacement when computing `BASE_TAG`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-devtoolsis skipped on everyscheduleand tag run, sosalt-dev-toolshas never been built or pushed for release tags or theweekly rebuild.
changesonly runs onpushto branches andpull_request.build-baseopts out of that skip withalways(), butbuild-devtools(which depends onbuild-base) does not, so theskipped ancestor propagates and
build-devtoolsis skipped too.Observed on:
v1.7.0tag run 38017898885v1.6.0tag run 25466530330Fix
Gate
build-devtoolsonalways() && needs.build-base.result == 'success' && github.event_name != 'pull_request'.PR behavior is unchanged (still skipped), and a failed or cancelled
build-basestill blocks it.Also fixed:
BASE_TAGfor branches with/Running devtools on this branch exposed a second, pre-existing bug.
build-basetags branch images viadocker/metadata-action, whichturns
/into-(paratools/salt-dev:fix-devtools-skipped-on-tags),but the devtools "Determine base tag" step passed the raw branch name:
The step now applies the same
/to-replacement. Push run38050836904 passes all jobs, including
build-devtools.Follow-up
Re-running the
v1.7.0tag run uses the workflow as of that tag, so itwill still skip devtools. After this merges, tag
v1.7.1to publishsalt-dev-tools:1.7.x.