Skip to content

SOCFWAssessmentDecisions: 10 minute timeout - #1252

Open
scottbrumley wants to merge 1 commit into
mainfrom
nist-ir-ai/assessment-decisions-timeout
Open

scottbrumley wants to merge 1 commit into
mainfrom
nist-ir-ai/assessment-decisions-timeout

Conversation

@scottbrumley

Copy link
Copy Markdown
Contributor

What this changes

SOCFWAssessmentDecisions gets timeout: 10m0s.

Why

The five post-assessment steps (promote, render, emergency response, elevate, close decision) used to be five tasks in EP_IR_NIST - AI, each with its own timeout. Since #1248 they run inside this one script and share its timeout. In shadow mode the step takes 4–33 s, but with live execution emergency response calls vendor APIs through SOCCommandWrapper, and a timeout part-way would leave an issue contained but not elevated or closed. 10m0s is what the other SOCFW scripts that do longer work use.

Not a SOCFWConfig setting: a script's timeout is part of its definition and isn't read from a list.

Tested on deathstar

  • check_contribution passed; the tenant's script reads back timeout: 600.
  • Unit tests unchanged and passing.
  • Live: replayed the malicious-contained and false-positive scenarios after the upload; see the comment below for the runs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VK24hKuKXVJfuVHg4Min9y

The five post-assessment steps used to be five tasks with a timeout each; in
one script they share one. Shadow mode takes 4-33 s, but live containment
calls vendor APIs through the wrapper. 10m0s matches the other SOCFW scripts
that do longer work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VK24hKuKXVJfuVHg4Min9y
@scottbrumley scottbrumley added the version:patch Bug fix or hotfix → x.x.N label Nov 12, 2026
@scottbrumley

Copy link
Copy Markdown
Contributor Author

Live on deathstar after the upload (script reads back timeout 600): malicious-contained (1501703, greta-lt-04) — AI task and Assessment Decisions completed, decisions step 12 s; false positive (1501704, it-adm-02) — completed, decisions step 5 s. No errored tasks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch Bug fix or hotfix → x.x.N

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant