Repository navigation
SOCFWAssessmentDecisions: 10 minute timeout - #1252
Open
scottbrumley wants to merge 1 commit into
Open
scottbrumley wants to merge 1 commit into
scottbrumley wants to merge 1 commit into
Conversation
The five post-assessment steps used to be five tasks with a timeout each; in one script they share one. Shadow mode takes 4-33 s, but live containment calls vendor APIs through the wrapper. 10m0s matches the other SOCFW scripts that do longer work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VK24hKuKXVJfuVHg4Min9y
Contributor
Author
|
Live on deathstar after the upload (script reads back timeout 600): malicious-contained (1501703, greta-lt-04) — AI task and Assessment Decisions completed, decisions step 12 s; false positive (1501704, it-adm-02) — completed, decisions step 5 s. No errored tasks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
SOCFWAssessmentDecisionsgetstimeout: 10m0s.Why
The five post-assessment steps (promote, render, emergency response, elevate, close decision) used to be five tasks in
EP_IR_NIST - AI, each with its own timeout. Since #1248 they run inside this one script and share its timeout. In shadow mode the step takes 4–33 s, but with live execution emergency response calls vendor APIs throughSOCCommandWrapper, and a timeout part-way would leave an issue contained but not elevated or closed. 10m0s is what the other SOCFW scripts that do longer work use.Not a SOCFWConfig setting: a script's timeout is part of its definition and isn't read from a list.
Tested on deathstar
check_contributionpassed; the tenant's script reads backtimeout: 600.🤖 Generated with Claude Code
https://claude.ai/code/session_01VK24hKuKXVJfuVHg4Min9y