Skip to content

SOCCommandWrapper: shadowed steps reach the wrapper, act once per target per case; SOCFWConfig sets the Case Analysis window - #1249

Merged
scottbrumley merged 4 commits into
mainfrom
unified/shadow-steps-reach-wrapper
Nov 12, 2026
Merged

scottbrumley merged 4 commits into
mainfrom
unified/shadow-steps-reach-wrapper

Conversation

@scottbrumley

Copy link
Copy Markdown
Contributor

What this changes

Commit Change
SOCFWConfig: which cases Case Analysis looks at Window, passes per case and unstarred-only are set through SOCFWConfig; ships 6 h and unstarred
Shadowed steps reach the wrapper Approval and directions-only gate only a live run; a shadowed step still reaches SOCCommandWrapper and is recorded
Act once per target per case A containment or eradication action runs once per target per case, whichever path asks
Wrapper resolves references inside longer args A ${...} inside a longer argument (runscript paths, ticket text, Panorama rule name) is replaced by its value and counted in the act-once key; effective-config snapshot regenerated (only the Panorama address name changes)

Tested

  • check_contribution passed and uploaded to deathstar.
  • Unit: 206 pass across SOCCommandWrapper, SOCFWConfig and SOCFWPhaseExecutor, including the new act-once and reference tests. test_main_production_rate_limited_soft_fails fails on main as well.
  • Live on deathstar earlier today, underneath the Foundation step reduction (Foundation: fewer engine steps per run; health check reports failing vendor calls #1247): 81 runs across Turla CrowdStrike + Proofpoint, Defender and Abnormal, plus the malicious-contained, false-positive, benign-remediated, ambiguous and thin-evidence scenarios, all completed; wrapper rows by action / vendor / outcome / mode showed no new combinations.

Merges first; #1247 rebases on it so main matches what was tested together.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VK24hKuKXVJfuVHg4Min9y

scottbrumley and others added 4 commits November 6, 2026 07:49
…er case and unstarred only; ships 6 h and unstarred
…ichever path asks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VK24hKw2iouqnQzg5TTExE
…e on them

A ${...} reference inside a longer argument (CrowdStrike runscript paths,
ticket text, the Panorama rule name) was sent literally. It is now replaced
by its value, and the act-once key counts it, so two files on one host are
two targets. Effective-config snapshot regenerated: only the Panorama
address name changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VK24hKw2iouqnQzg5TTExE
@scottbrumley scottbrumley added the version:patch Bug fix or hotfix → x.x.N label Nov 12, 2026
@scottbrumley
scottbrumley merged commit ba85501 into main Nov 12, 2026
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch Bug fix or hotfix → x.x.N

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant