Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Duddino
added
the
Performance
JSKitty
requested changes
Jun 7, 2024
Member
JSKitty
left a comment
JSKitty
left a comment
There was a problem hiding this comment.
Getting this error when attempting to create a new HD wallet:
Uncaught (in promise) TypeError: secp256k1.privateKeyVerify is not a function
set hdkey.js:36
fromMasterSeed hdkey.js:193
HdMasterKey masterkey.js:114
f parsed_secret.js:77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Through various dependencies we are currently using 3 different secp256k1 libraries.
The aim of this PR is to remove these dependencies in favor of @noble/secp256k1.
tiny-secp256k1
A noble based library was already developed by bitcoiner lab
secp256k1
A replacement for this library was developed in-house here.
The original tests are being used to test this version of the library.
Why switch to a single secp256k1?
Using a single library allows us to reduce the bundle size, and the potential vulnerabilities.
The other libraries have a larger amount of dependencies, like
elliptic.jsandbn.js, and as far as I can tell have not been audited.This brings the main bundle size down from 361KB to 325 KB(gzipped)
Testing
When testing is done, secp256k1-noble will be released on npm (With a better name)