Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Use the coarse reference index for conclusive zero counts and cache bounded exact member locations for non-zero lenses. Refresh-capable clients avoid eager resolve storms while older clients retain lazy resolution.
Stop reference counts and CodeLens resolves from repeating the full workspace walk for every declaration. Internal annotation requests share the initial index, including callers queued behind it, while an explicit Find References command keeps its single refresh for files created without watcher notifications.
sidux
force-pushed
the
fix/indexing-resource-startup-progress
branch
from
August 30, 2026 15:33
5b1be6f to
e561797
Compare
Resolve fully-qualified classes and Class::member references from arbitrary YAML and XML positions without schema-specific rules.
Feed schema-free class and member occurrences into Find References and CodeLens, including transparent-proxy metadata aliases.
Index semantic framework relationships alongside generic YAML and XML class references.
Pass every indexed target to editor-native navigation and ignore empty PHP resource strings.
Generic YAML and XML navigation now returns early only when it resolves a PHP symbol. Otherwise the semantic Symfony resolver still handles aliases, form fields, validation mappings, and configuration keys.
Build entity-to-repository pairs alongside the framework resource index and update them per URI. CodeLens and reference lookups now read the derived index instead of reopening and rescanning every YAML/XML resource for each declaration.
sidux
force-pushed
the
fix/indexing-resource-startup-progress
branch
from
August 30, 2026 15:54
e561797 to
7370ea9
Compare
The reference CodeLens and YAML/XML navigation this branch was built on landed upstream (PHPantom-dev#392, PHPantom-dev#394) and were reworked there, so this applies only the branch's own changes on top of main. - Member-scope resolution moved to references/member_scope.rs; the Doctrine getRepository() receiver resolution now lives there, using the namespace-aware use map, and framework member lookups filter through MemberScope. - Document open/change/close and startup indexing moved to backend/documents.rs and backend/startup.rs; the framework resource index hooks follow them. YAML/XML watchers already exist upstream. - Code lenses use the request's LineIndex; the framework method lens skips methods no resource names and builds its class scope once. - Rename keeps working across file types: YAML/XML class and namespace occurrences are rewritten by the framework index in each document's own spelling and verified one by one, so an escaped name can no longer cancel a rename. A rename started in a resource renames the PHP declaration it names. - Fix namespace segment indexing for escaped (App\\Domain) and rooted (\App\Domain) spellings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tartup-progress Brings in main through the updated framework-resource-navigation branch. - The progress hand-off follows startup indexing to backend/startup.rs, where the framework resource walk now runs on a blocking thread like the other startup indexes instead of on the async runtime. - The preload counter moves after the parse inside upstream's parallel map, so reported progress never runs ahead of the work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Startup could appear frozen while expensive work continued behind a percentage that no longer described the active phase. Large configuration files also paid repeatedly to convert byte offsets into line and column positions. Reporting completed work and reusing one line index makes progress smoother and removes avoidable repeated scanning.
Dependencies
Validation