GS/CLUT: Handle special case for CSM2 32bit mode switch#14546
Merged
Conversation
Member
Author
|
It has been confirmed that the behaviour here is incorrect and it's not what we thought. Further testing is being done, but we'll see. |
refractionpcsx2
marked this pull request as draft
July 10, 2026 21:05
refractionpcsx2
force-pushed
the
gs_delayclutreload
branch
from
July 11, 2026 05:00
c0546d4 to
80d1bb1
Compare
Member
Author
|
I kinda just went "fuck it" and made a non-invasive special case for this game, I don't know of any other games that do it and I really don't want to mess about trying to implement it for all scenarios which will never get used. |
refractionpcsx2
marked this pull request as ready for review
July 11, 2026 05:01
refractionpcsx2
force-pushed
the
gs_delayclutreload
branch
from
July 11, 2026 05:02
80d1bb1 to
7d36784
Compare
refractionpcsx2
changed the title
JordanTheToaster
approved these changes
Jul 15, 2026
Mrlinkwii
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Changes the behaviour of CLUT storage mode 2 to always load the CLUT from local memory and not in to a temporary buffer.
Rationale behind Changes
This is kind of theoretical based on the behaviour of Breath of Fire - Dragon Quarter when running a GS Dump vs PCSX2, the game will reload the CLUT in Storage Mode 1, then switch to Storage Mode 2, however the data loaded from Mode 1 is in the incorrect order, due to it being correctly swizzled and Mode 2 is sequential, meaning the main colour the text uses on the menu has black holes everywhere.
The running theory is that Mode 2 reads directly from GS memory when loading the texture cache (hence it being slower than CSM 1, along with the swizzle differences). I can't see any other way that this game would have the correct CLUT otherwise.
Ziemas is likely going to run some tests on his PS2 to try and confirm the theory, but this is the best we have for now, the dump run seems clean, to it may hold water.
Suggested Testing Steps
Test Breath of Fire - Dragon Quarter
Did you use AI to help find, test, or implement this issue or feature?
I did ask AI for some possible information on the web w/links that I failed to find and anything which backed up my theory, but didn't really help with any credible information.
Fixes #14543
Breath of Fire - Dragon Quarter
Master:
PR:
