Achievements: Group leaderboards by subset and tracking state#14402
Merged
Conversation
JordanTheToaster
approved these changes
May 6, 2026
Mrlinkwii
suggested changes
May 6, 2026
Mrlinkwii
left a comment
Mrlinkwii
left a comment
Contributor
There was a problem hiding this comment.
reminder for navigation fix
Contributor
|
Nevermind, just when i thought it was done, i found an issue. The close button on the top right doesn't work when you click it. |
JordanTheToaster
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The leaderboard screen now sorts boards into clearer groups (like "inactive" vs "active"). Games that split content into subsets get a left sidebar to go between those subsets, similar to achievements. Some stuff got moved into helpers so both menus behave the same way and less duplicate code.
Also made it so we don't use the dpad to go between subsets instead it will use Confirm or Cancel
Resolves #13658
Rationale behind Changes
It’s easier to find the leaderboard you care about when the list isn’t one giant pile.
Suggested Testing Steps
Open Achievements in the pause menu, go to Leaderboards (and Achievements too), go through subsets if your game has them, (ex: Gran Turismo 4) open/close the grouped sections, and try keyboard and controller to make sure nothing feels broken.
Did you use AI to help find, test, or implement this issue or feature?
No