Skip to content

LMDB (5c) Run both FS backend and LMDB backend in Github Actions#685

Open
subygan wants to merge 3 commits into
ENG-1159/fix-testfrom
ENG-1159/CI-lmdb-tests
Open

LMDB (5c) Run both FS backend and LMDB backend in Github Actions#685
subygan wants to merge 3 commits into
ENG-1159/fix-testfrom
ENG-1159/CI-lmdb-tests

Conversation

@subygan

@subygan subygan commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

enable running all tests with both LMDB and File system

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63e86433-fd8d-46d2-bbe1-7ceee68cb19f

📥 Commits

Reviewing files that changed from the base of the PR and between 52fcd6e and 7584484.

📒 Files selected for processing (1)
  • .github/workflows/ci_test.yml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Expanded automated Rust test coverage in CI with an additional test run to improve reliability and catch more failures without stopping at the first error.

Walkthrough

A new CI step is added to the rust-test job that sets OXEN_MERKLE_NODE_BACKEND=lmdb and runs cargo nextest run --no-fail-fast, executing after the existing Rust test steps.

LMDB Backend CI Step

Layer / File(s) Summary
LMDB backend test step
.github/workflows/ci_test.yml
Adds a cargo nextest run step with OXEN_MERKLE_NODE_BACKEND=lmdb and --no-fail-fast to the rust-test job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through CI lanes,
With LMDB now in the chains,
No fail-fast slows the warren down,
Each test gets run without a frown,
🐇 Merkle trees in lmdb bloom!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the CI change to run tests against both the file system and LMDB backends.
Description check ✅ Passed The description is directly related and correctly states the goal of running tests with both backends.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ENG-1159/CI-lmdb-tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant