Rename Reference Numbers to Scan IDs#532
Merged
Merged
Conversation
Contributor
|
Cool! Please add @sadhana-r to review when ready for review |
peterhollender
force-pushed
the
531-rename-photocollection-reference-number
branch
from
0ae01e3 to
26bd98b
Compare
Closes #531 Co-Authored-By: Peter Hollender <peterhollender@gmail.com>
ebrahimebrahim
force-pushed
the
531-rename-photocollection-reference-number
branch
from
26bd98b to
4be5103
Compare
ebrahimebrahim
approved these changes
Apr 2, 2026
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
Contributor
There was a problem hiding this comment.
I hard-reset to main and re-did the find-and-replace.
Then made sure this didn't break the usage of the openlifu API which still has "reference number" in some funciton names, so I had to revert just those function calls
Tested (without android app) and it seems good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531