Skip to content

feat: apply AI voice preferences - #6

Merged
AndyH0ng merged 1 commit into
mainfrom
feat/ai-voice-preferences
Aug 25, 2026
Merged

AndyH0ng merged 1 commit into
mainfrom
feat/ai-voice-preferences

Conversation

@AndyH0ng

@AndyH0ng AndyH0ng commented Aug 25, 2026 •

Copy link
Copy Markdown
Member

변경 사항

  • LiveKit 텍스트 스트림의 음성 종류 및 속도 메타데이터 처리
  • 차분한, 밝은, 또렷한 발화 스타일과 느림, 보통, 빠름 속도 지시 적용
  • 알 수 없는 설정값에 안전한 기본값 적용

검증

  • Python agent tests: 5 passed, 1 skipped

Summary by CodeRabbit

  • New Features

    • Improved Korean speech generation using configured voice and speed preferences.
    • Added calm voice and normal speed defaults when unsupported settings are provided.
  • Bug Fixes

    • Speech requests now consistently apply text-stream voice attributes instead of using raw text alone.
  • Tests

    • Added coverage for voice preferences, speed preferences, and safe fallback behavior.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f2624652-88dd-44e9-bde4-f59bccc1cc13

📥 Commits

Reviewing files that changed from the base of the PR and between 5e6d0cd and 62d1a88.

📒 Files selected for processing (3)
  • agent/agent.py
  • agent/logic.py
  • agent/tests/test_logic.py

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The speech handler now reads voice and speed attributes from the text stream. It uses speech_prompt to build a Korean instruction with fallback defaults before sending the realtime chat message. Tests cover configured and unknown voice settings.

Changes

Speech prompt flow

Layer / File(s) Summary
Speech prompt construction
agent/logic.py, agent/tests/test_logic.py
speech_prompt maps voice and speed settings to Korean instructions. Tests cover configured preferences and fallback behavior.
Speak handler integration
agent/agent.py
The speak handler passes text and reader attributes to speech_prompt before constructing the realtime chat message.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 62d1a

This localized change applies voice preferences with safe defaults, and no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant speak
  participant speech_prompt
  participant RealtimeChat
  speak->>speech_prompt: text and reader attributes
  speech_prompt-->>speak: Korean speech prompt
  speak->>RealtimeChat: prompt in chat message
Loading

Suggested reviewers: perasite

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: applying AI voice preferences to speech generation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ai-voice-preferences

Comment @coderabbitai help to get the list of available commands.

@AndyH0ng
AndyH0ng merged commit f695d70 into main Aug 25, 2026
8 of 9 checks passed
@AndyH0ng
AndyH0ng deleted the feat/ai-voice-preferences branch August 25, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant