You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(sync): let devices share confirmed deletions through a syncDeletions collection - #49
OpenTubeX asks before applying deletions that would empty a synced list, because it can't tell another device's deletion from a server that lost the data. When you unsubscribe from 3 or more channels on one device, sync pauses on your other devices until someone confirms there. OpenTubeX#3342 lets a device share the deletions its user confirmed in an encrypted syncDeletions collection, so the other devices apply them without asking. The app only does this when /health reports sync_deletions: 1.
The server now accepts the syncDeletions collection with a 16 MiB limit and reports sync_deletions: 1. The README lists the collection and the capability. Clients share this collection across profiles, so it has no per-profile scope.
Proof: the existing limit and /health tests now cover the collection and the capability. cargo test (107 tests), cargo fmt --check and cargo clippy --all-targets pass. I ran this branch locally and pointed the OpenTubeX network sync E2E tests at it: 12 passed and 1 skipped by design. That includes a new two-device test from OpenTubeX#3365, in which one device removes all 3 subscriptions and the other applies the removal and keeps automatic sync on. With sync_deletions hidden from /health, the same test fails with "Sync stopped because it would delete 3 of 3 previously synced subscriptions items".
Changes made by Claude Opus 5.5 in Claude Code (T3 Code).
No actionable comments were generated in the recent review.
Walkthrough
The server adds the sync_deletions capability, advertises it with value 1, and accepts the syncDeletions collection with a 16 MiB limit. Tests and the README reflect these additions.
Changes: sync_deletions support
Layer / File(s)
Summary
Capability and collection support src/dto.rs, src/handlers/encrypted_sync.rs, src/handlers/health.rs, README.md
SyncCapabilities adds sync_deletions. The encrypted-sync handler advertises the capability as 1 and accepts syncDeletions with a 16 MiB limit. Tests and the README cover these declarations.
This change advertises the sync_deletions capability and accepts the syncDeletions collection with a 16 MiB limit. It is additive and covered by tests and documentation. No merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: a syncDeletions collection that lets devices share user-confirmed deletions. It matches the changeset, which adds the collection, its 16 MiB limit, and the sync_deleti…
Description check
The description explains the purpose (sharing confirmed deletions through an encrypted syncDeletions collection), the capability gate on /health, the 16 MiB limit, the README update, and the test and …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: a syncDeletions collection that lets devices share user-confirmed deletions. It matches the changeset, which adds the collection, its 16 MiB limit, and the sync_deletions capability. It uses the conventional feat(sync) prefix and is specific.
Full details: Description check
Explanation
The description explains the purpose (sharing confirmed deletions through an encrypted syncDeletions collection), the capability gate on /health, the 16 MiB limit, the README update, and the test and E2E evidence. It is directly related to the changeset.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4c900fd7-42ff-4c4d-a4ff-31336d9b1155
Commits
Reviewing files that changed from the base of the PR and between 389d21e and 8c2d902.
Files selected for processing: 4
README.md
src/dto.rs
src/handlers/encrypted_sync.rs
src/handlers/health.rs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTubeX asks before applying deletions that would empty a synced list, because it can't tell another device's deletion from a server that lost the data. When you unsubscribe from 3 or more channels on one device, sync pauses on your other devices until someone confirms there. OpenTubeX#3342 lets a device share the deletions its user confirmed in an encrypted
syncDeletionscollection, so the other devices apply them without asking. The app only does this when/healthreportssync_deletions: 1.The server now accepts the
syncDeletionscollection with a 16 MiB limit and reportssync_deletions: 1. The README lists the collection and the capability. Clients share this collection across profiles, so it has no per-profile scope.Proof: the existing limit and
/healthtests now cover the collection and the capability.cargo test(107 tests),cargo fmt --checkandcargo clippy --all-targetspass. I ran this branch locally and pointed the OpenTubeX network sync E2E tests at it: 12 passed and 1 skipped by design. That includes a new two-device test from OpenTubeX#3365, in which one device removes all 3 subscriptions and the other applies the removal and keeps automatic sync on. Withsync_deletionshidden from/health, the same test fails with "Sync stopped because it would delete 3 of 3 previously synced subscriptions items".Changes made by Claude Opus 5.5 in Claude Code (T3 Code).