Skip to content

Remove __declspec() properties, for gcc compatibility. - #167

Open
daliborfox wants to merge 1 commit into
OpenTS-Developers:mainfrom
daliborfox:remove-declspec-properties
Open

daliborfox wants to merge 1 commit into
OpenTS-Developers:mainfrom
daliborfox:remove-declspec-properties

Conversation

@daliborfox

Copy link
Copy Markdown
Contributor

This pull request removes the __declspec(property()) fields from the classes in OpenTS, which is a necessary step towards enabling gcc build support.

An alternative would be to introduce a Property class which would contain operator overloading for the value retrieval and assignment on itself to the appropriate getter/setter functions.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Development builds of 16e384d:

The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build.

@daliborfox
daliborfox force-pushed the remove-declspec-properties branch from 0599fd8 to 730a4d1 Compare September 21, 2026 17:37
@daliborfox
daliborfox force-pushed the remove-declspec-properties branch from 730a4d1 to 16e384d Compare September 21, 2026 17:50
@daliborfox

Copy link
Copy Markdown
Contributor Author

I had accidentally messed up the line endings in the combuf.cpp file, it should be good now.

I tried to make the changes in the safest way possible, where I've indidivually went through the __declspec(property()) properties, commented one of them out, examined the error log, and then replaced the accesses where applicable with the getter()/setter() until it compiled clean, after which I've moved onto the next property.

The game appears to run correctly, I haven't observed any significant glitches while playing through 2 missions.

I recommend putting on a podcast while reviewing the changes :) There's a lot of them, but they're quite mechanical / monotonous.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant