Refactor aerodynamics#229
Merged
Merged
Conversation
The winch-interface refactor (#210) dropped the `speed_controlled` field, which broke the V3Kite flight-replay path that prescribes reel-out velocity from recorded CSV data. Add it back as a runtime-switchable flag: when `winch.speed_controlled` is true, `winch_acc` is forced to 0 (ignoring the winch component's `acc` output), so `D(winch_vel) = 0` and velocity is prescribed via `winch.vel`. Implemented with the registered `get_speed_controlled` accessor so it takes effect without recompiling, matching the pre-refactor behavior. Caveat: the model cache key (set_hash + sys_struct_hash) does not capture this equation change, so existing cached binaries must be rebuilt (remake=true) for the restored branch to take effect. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collapse BaseWing/VSMWing/PlateWing into a single `Wing` type. VSM state moves into a `VSMEngine` sub-struct on `wing.vsm`. The engine is wing infrastructure shared by all aero modes — an AeroNone wing still carries it for section matching and twist-surface geometry — so it lives on the wing, not in the aero mode. VSMWing/PlateWing become constructor functions that return a Wing; `wing isa VSMWing/PlateWing` become `is_vsm`/`is_plate`. Flat-plate aero now goes through `aero_component(::AeroPlate, ...)` on the same PARTICLE connector contract as the other per-point modes, extended with per-point `va`/`rho` (the only inputs plate needs; VSM particle modes ignore them). Deletes plate_eqs.jl and its bespoke wiring branch. RHS aero getters are function-barriered on the concrete VSMEngine for type-stable, allocation-free reads. Full suite green (1174/1174), zero alloc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.