Skip to content

Display keyboard shortcuts in the map editor toolbar#2512

Open
mfbehrens wants to merge 1 commit into
OpenOrienteering:masterfrom
mfbehrens:keyboard-shortcuts
Open

Display keyboard shortcuts in the map editor toolbar#2512
mfbehrens wants to merge 1 commit into
OpenOrienteering:masterfrom
mfbehrens:keyboard-shortcuts

Conversation

@mfbehrens

@mfbehrens mfbehrens commented Jun 2, 2026

Copy link
Copy Markdown

I am really missing getting the hotkeys displayed in OOMapper.
This is probably a problem that most maintainers here don't have, but when you start using this software you don't know all the hotkeys by heart.
Looking them up all the time is annoying and in the beginning most users probably don't know that they exist.
Displaying them whenever hovering over the icons really helps learning them.

Unfortutnately I am too stupid to actually take a screenshot of it, but it displays:

  • Edit objects (E)
  • Edit lines (L)
  • Set point objects (S)
  • and so on

AI was used during programming. I tried my best and I hope it is not complete garbage.

Edit:
image

@mfbehrens mfbehrens force-pushed the keyboard-shortcuts branch from 68d7384 to 73d71cf Compare June 2, 2026 01:49
@dg0yt

dg0yt commented Jun 2, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution.
I understand what you are trying to achieve is to display the keyboard shortcut in the tooltip of toolbar items. (The toolbar doesn't display text.)
I like the idea. But I see two problems:

  • Changing the text of the action has side effects when other means are used to also show the shortcut. In particlar, in the menu.
    Bildschirmaufzeichnung vom 02.06.2026, 22:04:56.webm
    I would really like to avoid this pattern. I do not know if it is possible, but I suppose this would need to be handled on the fly when the tooltip is constructed.
  • I increasingly lean towards rejecting code contributions based on use of LLMs.
    This is not a specific assessment of this PR or your work. This PR is small and a reasonable.
  • Nitpick: piecewise string construction can create problems for internationalization, in particular for right-to-left (RTL) languages. (Not tested.)

@mfbehrens

Copy link
Copy Markdown
Author

Thank you for your feedback. I understand your three points.

However, I am still convinced that the feature would really help (new) users of the app.
Do you have a good idea how a feature like this could be implemented?

Otherwise, you can just close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants