Repository navigation
feat: wire the Glorious Model O 2 PRO 4K/8K driver into the connect flow - #675
Merged
Merged
Conversation
Adds GloriousCore2HidClient to NEEDS_OPEN so its input-report handling is set up on connect, gives the glorious-core2 family the advanced section and the debounce card in traits (it has no sleep command wired in), and marks the Model O2 Pro 4K/8K as having a driver PR in the supported mirror (only that row). An availability test covers the cards the family opens: debounce, Motion Sync and the profile card, but not sleep or signal. Needs the mouse-protocol release that contains the driver before the @openmouse/protocol pin can be bumped. Requested in Discord ticket 0160. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tocol to 0.30.0 Resolve NEEDS_OPEN conflict as union: keep GloriousCore2HidClient wiring from this branch plus main's CorsairBragiHidClient and AjazzHidClient. Bump @openmouse/protocol 0.29.0 -> 0.30.0 so drivers/glorious/core2-hid resolves (shipped in 0.30.0).
snekxs
marked this pull request as ready for review
October 8, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture from Discord ticket 0160. Needs OpenMouse-Project/mouse-protocol#181 released before the
@openmouse/protocolpin can be bumped, hence draft. Catalog: OpenMouse-Project/openmouse-landing-page#37.src/device/controller.ts:GloriousCore2HidClientinNEEDS_OPEN, so it is opened on connect.src/device/traits.ts: theglorious-core2family gets the advanced section and the debounce card. There is no sleep flag, because the driver has no sleep command wired in.src/supported-devices-data.ts: the Model O2 Pro 4K/8K as "pr" (only that row).src/app/cards/availability.test.ts: the cards the family opens (debounce, Motion Sync and the profile card, not sleep or signal). The test fails without the traits entry.The driver reports
profileCount: 3andactiveProfile, so the generic Profile card appears next to the DPI stage editor, the polling row up to 8K, and the Debounce and Motion Sync cards. I checked that in the dev preview with a temporary fixture built from the real client's status (not committed): the cards render, and the only console errors were the Bridge socket not running locally.Verification
Against a local build of the protocol branch:
tsc --noEmitclean,npm test293 pass,vite buildOK, bundle size within budget (JS at 98%). Not tested on hardware.