api+webui: expose mDNS discovery config fields (v0.18.1)#90
Merged
snokvist merged 1 commit intoJun 24, 2026
Merged
Conversation
The discovery config section (enabled/serviceType/name/bareAlias) added in the mDNS beacon work (0.18.0) was wired into the loader/serializer but never registered in g_fields[], so it was unreachable via /api/v1/set, /api/v1/capabilities, and the WebUI dashboard — editable only by hand in /etc/waybeam.json. - venc_api.c: register the 4 discovery fields in g_fields[] (all MUT_RESTART — beacon reads config at boot, no live re-announce path) + camelCase aliases for serviceType/bareAlias - web/dashboard.html: add a Discovery SECTIONS group + field tooltips - src/venc_webui.c: regenerated blob (make webui) - VERSION -> 0.18.1, HISTORY.md entry, HTTP_API_CONTRACT.md capabilities list No protocol or beacon behavior change. Host tests: 1701 passed, 0 failed. make verify clean (both backends). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
discoveryconfig section added with the mDNS device beacon (0.18.0) was wired into the config loader/serializer but never registered in the API field table (g_fields[]), so it was unreachable via/api/v1/set,/api/v1/capabilities, and the WebUI dashboard — editable only by hand-editing/etc/waybeam.json.This registers the four fields and surfaces them in the dashboard. No protocol or beacon behavior change.
Changes
src/venc_api.c: registerdiscovery.{enabled,service_type,name,bare_alias}ing_fields[](allrestart_required— the beacon reads config at boot / re-reads on SIGHUP-respawn, with no live re-announce path), plus camelCase aliases forserviceType/bareAlias.web/dashboard.html: new Discovery settings section + per-field tooltips.src/venc_webui.cblob regenerated (make webui).HISTORY.mdentry,HTTP_API_CONTRACT.mdcapabilities list.Verification
make verifyclean on both backends (star6e + maruko); host tests pass./api/v1/capabilitiesasrestart_required(absent before).discovery.name,discovery.bareAlias) and canonical snake_case (discovery.enabled); each returnsreinit_pending:true, persists to disk, and survives the respawn.discovery.enabled=false→ the 5353 mDNS listener disappears; re-enabling brings it back.