feat(sensors): show expected and actual sampling rates - #303
Merged
Merged
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit 60fab59): https://open-earable-web--pr303-codex-sensor-samplin-6hmmjaom.web.app (expires Thu, 29 Oct 2026 11:54:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/36857967492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small grey expected/actual Hz label in the top-right of compact and full sensor graphs, using the configured sensor rate and existing rolling sample buffer.
Validation:
flutter analyze,flutter test(92 passed), and manual checks of label alignment and the toggle on a Pixel 9a.