Skip to content

DESIGN-CHANGES.md

Latest commit

 

History

History
208 lines (176 loc) · 10.7 KB

DESIGN-CHANGES.md

File metadata and controls

208 lines (176 loc) · 10.7 KB
Raw

DESIGN-CHANGES — CastCodes UI/UX Modernization

Tracks Phase 1 of the OpenCoven brand-identity rebrand.

Repo-level guardrails

  • New root AGENTS.md defines the CastCodes-specific agent rules: no AI attribution, staged rebrand discipline, Phase 1 design constraints, and verification expectations.
  • New script/check_ai_attribution blocks generated-by/model-credit artifacts while still allowing AI/model names in real product behavior, compatibility notes, specs, and tests.
  • README.md now includes the attribution guard alongside the rebrand guard so public-surface changes run both checks together.

Scope reconciliation

The original Phase 1 scope was written against a Zed-style codebase layout (crates/theme, crates/title_bar, crates/workspace/src/pane.rs, crates/project_panel, pane::ToggleTabBar, cargo check -p zed).

This repository is the Warp fork rebranded as CastCodes. The relevant paths here are:

Zed-style path This repo
crates/theme app/src/themes/
crates/workspace/src/pane.rs app/src/workspace/, app/src/tab.rs (1905 LoC)
crates/title_bar rendered via warpui in app/src views
crates/workspace/src/status_bar.rs app/src/shell_indicator.rs + tab decorations
crates/project_panel, crates/outline_panel not present (Warp has no project panel)
crates/editor crates/editor (already exists)
cargo check -p zed cargo check -p warp-app --bin cast-codes --features gui

WarpTheme::new() accepts seven concrete slots (background fill, foreground color, accent fill, optional gradient, details preset, terminal ANSI palette, optional background image, display name). Additional brand slots from the original scope but not present on WarpTheme (surface, elevated surface, border, text secondary, text muted, accent secondary gold, status bar bg, title bar bg) have no direct theme slot to map onto — they are computed downstream from details + background + accent in dependent UI crates.

Applied (this PR)

GitHub-Flavored Markdown preview

CodeView's .md Rendered preview now renders the GFM HTML safe-list (<details>, <summary>, <kbd>, <sub>, <sup>, <del>, raw <table>, <img>, plus inline phrasing tags) and GFM footnotes ([^id] references with [^id]: definitions). <details> blocks render always-expanded with a ▾ glyph; interactive collapse is not provided in v1. Mermaid blocks render as SVG diagrams in the preview, unchanged from prior behavior. Inline HTML is parsed via the existing html5ever pipeline in markdown_parser; no new dependencies were added.

Brand rebrand sweep

  • app/src/drive/index.rs:109 — WARP_DRIVE_TITLE literal updated from "Warp Drive" to "Cast Drive".
  • app/src/drive/index.rs:3962 — header label now reads from the constant rather than a duplicated string literal.
  • app/src/search/data_source.rs:316 — QueryFilter::Drive display label updated to "Cast Drive".
  • Existing app/src/settings_view/mod.rs:339-341 aliases ("Cast Drive" | "WarpDrive" | "Warp Drive", "Familiar" | "Cast Agent" | "Warp Agent") preserve back-compat with persisted user settings per CASTCODES.md naming rules.

Familiar agent rename

  • The user-visible integrated agent is renamed from "Cast Agent" to "Familiar" across all display strings: the AgentBackend::agent_name() return value, AI_ASSISTANT_FEATURE_NAME/ASK_AI_ASSISTANT_TEXT, the agent panel labels and transcript headers, the SettingsSection::WarpAgent display name, AI settings/MCP copy, command-search items, and the onboarding agent slide. Internal identifiers (cast_agent crate, CastAgent, the SettingsSection::WarpAgent variant) are unchanged per the staged-rebrand policy.
  • SettingsSection::from_str now accepts "Familiar" in addition to the retained "Cast Agent"/"Warp Agent" back-compat aliases, so persisted settings and deep links keep resolving after the rename.

Design tokens (shadcn-style)

  • New resources/design-tokens.css captures the full brand palette as CSS custom properties using shadcn/ui semantic aliases (--background, --card, --primary, --ring, --destructive, etc.).
  • Single source of truth for any web-side surface (docs site, marketing, future plugin host UI) so the same hex values stay in sync with the native castcodes_dark theme. The native theme is the authoritative consumer for the GPUI app; this file mirrors it.
  • The token contract is intentionally minimalist: 4px compact radius, 6px controls, 8px maximum large-surface radius, 100-150ms motion, title/status chrome at #0a0a0d, and gold used only as a sparse highlight.

Feature flags

  • crates/ai/Cargo.toml — added default = ["cast-agent"] plus the cast-agent and warp-agent features. cast-agent pulls in the new crates/cast_agent as an optional dep. warp-agent is declared without removing the existing unconditional warp_* deps because they are used outside agent paths; call-site #[cfg(feature = "...")] gating is the follow-up step. Verified with cargo check -p ai.
  • Cargo.toml workspace deps table — registered cast_agent = { path = "crates/cast_agent" } so other crates can consume it via cast_agent.workspace = true.

1.1 Theme — castcodes_dark

  • New theme function castcodes_dark() in app/src/themes/default_themes.rs with the OpenCoven palette:
    • background: #0F0F12
    • foreground (text primary): #E8E8ED
    • accent (purple): #7C3AED
    • details: Darker (so derived surfaces darken correctly)
    • terminal ANSI: uses a CastCodes-specific dark palette derived from the Phase 1 brand tokens rather than the generic dark theme palette.
  • New ThemeKind::CastCodesDark variant in app/src/themes/theme.rs; marked #[default] so it is the first-launch theme. The previous default (ThemeKind::Dark) is preserved as a selectable theme.
  • Registered in WarpThemeConfig::new() and used as the fallback for WarpThemeConfig::theme() when an unknown kind is requested.
  • Added to the onboarding theme picker (app/src/themes/mod.rs) in slot 0, replacing the prior plain "Dark" entry.
  • SelectedSystemThemes::default() now also uses CastCodesDark for the dark-mode branch, so enabling system-theme matching does not silently revert CastCodes back to the generic upstream dark theme.
  • app/src/settings/initializer.rs now treats CastCodesDark as the new-user default when the legacy Adeberry feature-flag override is enabled.

1.2 Collapsible tab bar

  • Added WorkspaceAction::ToggleTabBar and the editable workspace:toggle_tab_bar binding.
  • Bound horizontal tab-bar collapse to cmd+shift+b / ctrl+shift+b. The existing vertical-tabs-panel binding keeps the same keystroke only when vertical tabs are active, so the two actions stay context-separated.
  • Added an in-session Workspace::tab_bar_collapsed flag. Collapsing the tab bar closes tab-bar popups, hides the tab strip, and leaves a 2px accent-purple reveal line with an expand chevron.
  • Hovering the reveal area temporarily shows the full tab bar again; the expand chevron toggles the persistent collapsed state off.
  • Covered the manual collapse mode resolver with targeted unit tests.

Deferred (follow-up PRs)

The remainder of Phase 1 was originally deferred here. Items 1.3–1.8 have since landed via the semantic-token pass below.

1.3 Title bar / 1.4 Status bar / 1.5 Sidebar / 1.6 Editor area / 1.7 Inputs / 1.8 Buttons — landed

Implemented with the "refactor WarpTheme to expose semantic slots" approach, reusing the existing optional UiTokens block rather than adding new theme fields:

  • UiTokens brand slots (crates/warp_core/src/ui/theme/mod.rs): the tweakcn-aligned token block gained CastCodes extensions — chrome (title/status bar bg), border_strong, border_subtle, primary_hover, and highlight (gold). All optional, hex-serialized, and skipped when absent, so imported/user themes are unaffected.
  • Provenance-free builder: WarpTheme::with_ui_tokens sets the token block without the tweakcn source provenance that with_ui records.
  • Full token block on castcodes_dark (app/src/themes/default_themes.rs::castcodes_ui_tokens): every brand slot from resources/design-tokens.css, with border tokens pre-blended to opaque over #0f0f12 (hex serialization is RGB-only): 8% white → #222225, 12% → #2c2c2e, 4% → #19191b.
  • Fallback-aware accessors (crates/warp_core/src/ui/theme/color.rs): surface_1()→muted, surface_3()→popover, sub_text_color()→ secondary_foreground, hint_text_color()→muted_foreground, plus new border_strong(), border_subtle(), chrome_bg_override(), accent_hover()/accent_hover_override(), and highlight_override(). Every accessor falls back to the previous derived value when the token is absent, so the 23 legacy built-in themes stay pixel-identical (guarded by builtin_themes_render_identically_without_ui_block and new_brand_accessors_fall_back_without_ui_block).
  • Render-site wiring: the tab/title strip takes chrome_bg_override() (app/src/workspace/view.rs::render_tab_bar); the right panel and vertical-tabs panel honor ui_sidebar_override() like the left panel already did; SubmittableTextInput uses a 6px control radius and a ring() border when focused; PrimaryTheme buttons hover with accent_hover_override(). Warp has no separate bottom status bar — the chrome token covers the single title/tab strip.
  • Radius sweep: modal surfaces previously at 10–12px (auth, launch modal, codex modal, environments page) were clamped to the 8px contract maximum. Remaining radii are named constants within the 4/6/8px scale.
  • Motion: warpui has no transition/easing primitive for hover states, so no timing normalization was needed; nothing bouncy exists. Revisit if an animation primitive is introduced.

Build verification

  • cargo test -p warp_core ui::theme ✅ (31 tests).
  • cargo test -p warp-app --features gui --lib themes:: ✅ (39 tests, plus the new brand-token and fallback-parity tests).

Recommended verification before merge:

./script/check_rebrand
cargo check -p warp-app --bin cast-codes --features gui