Use path, rather than URL for some Magellan fields#110
Closed
bmcdonald3 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Collaborator
|
I don't think we want to strip off the first part here like this since we will lose information. Current output: {
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0",
"manufacturer": "HPE",
"system_type": "Physical",
"name": "Node0",
"model": "HPE CRAY EX235a",
"serial": "NUX9940765739",
"bios_version": "ex235a.bios-1.3.6",
"ethernet_interfaces": [
{
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0/EthernetInterfaces/ManagementEthernet",
"mac": "02:0b:b8:00:30:00",
"description": "Node Maintenance Network"
},
{
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet2",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet1",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet3",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "https://172.21.0.1:5000/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet0",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
}
],
"power": {
"state": "On"
},
"processor_count": 9,
"processor_type": "AMD INSTINCT MI200 (MCM) OAM LC",
"memory_total": 512,
"links": {}
}New output: {
"uri": "/redfish/v1/Systems/Node0",
"manufacturer": "HPE",
"system_type": "Physical",
"name": "Node0",
"model": "HPE CRAY EX235a",
"serial": "NUX9940765739",
"bios_version": "ex235a.bios-1.3.6",
"ethernet_interfaces": [
{
"uri": "/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet2",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet1",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "/redfish/v1/Systems/Node0/EthernetInterfaces/ManagementEthernet",
"mac": "02:0b:b8:00:30:00",
"description": "Node Maintenance Network"
},
{
"uri": "/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet3",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
},
{
"uri": "/redfish/v1/Systems/Node0/EthernetInterfaces/HPCNet0",
"mac": "Not Available",
"description": "SS11 200Gb 2P NIC Mezz REV02 (HSN)"
}
],
"power": {
"state": "On"
},
"processor_count": 9,
"processor_type": "AMD INSTINCT MI200 (MCM) OAM LC",
"memory_total": 512,
"links": {}
} |
Member
Author
|
What information is lost? Assuming that node0 is the real xname, that is essentially the alias for the |
Collaborator
|
Can you parse the path on the SMD side using |
Collaborator
|
Closing this in favor of OpenCHAMI/smd#70. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Magellan, some of the fields were being added to SMD with full paths (i.e., they had
https://<hostname>/appended to the start. This was causing unexpected behavior when these fields are attempted to be used by other services (e.g., PCS).This PR fixes that by stripping off the URL elements and just leaving the path. Note, this is very similar in it's need to #98.
Commands to run:
Here is the contents of a single record in collected.txt without these changes:
Here is the contents of collected.txt with these changes:
Here is what we were seeing in SMD before:
Here is what we see in SMD after:
Now we see:
Before we were seeing:
This PR also changes the other fields, like the ethernet info, but the what I needed for PCS wer the two listed above.