feat: enhance SMDClient with group membership caching and reverse indexing#109
Merged
Conversation
…exing Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…mance tests Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the
SMDClientimplementation by improving concurrency safety, adding efficient reverse lookup indexes for node identification, and supporting group membership information for nodes. It also updates the tests to match these changes. The main improvements are grouped below:Concurrency and Data Structure Improvements
nodesMutexfrom async.Mutexto async.RWMutexthroughout the codebase to allow multiple concurrent readers, improving performance for read-heavy workloads. [1] [2] [3] [4] [5] [6] [7] [8] [9]ipToXname,macToXname,wgipToXname) toSMDClientfor O(1) lookups by IP, MAC, or WGIP, and updated all relevant methods to use these indexes for faster node identification. [1] [2] [3] [4]Node and Group Membership Enhancements
NodeMappingstruct to include aGroupsfield, and modifiedPopulateNodesto fetch and store group membership information for each node. TheGroupMembershipmethod now returns cached group data instead of querying the server each time. [1] [2] [3] [4]Test Updates
sync.RWMutex. Enhanced test HTTP handlers to simulate group membership endpoints, ensuring group membership and reverse lookup logic are tested. [1] [2] [3] [4] [5] [6] [7]These changes collectively improve the efficiency, scalability, and feature set of the
SMDClient.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
For more info, see Contributing Guidelines.