[codex] cleanup legacy permission modes#236
Open
Gucc111 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dontAskandacceptEditspermission modes from core/runtime/public types.defaultso old clients and local storage do not fail hard.default,plan, andbypassPermissionsbehavior intact.Closes #219
Validation
rg -n "dontAsk|acceptEdits" . --glob '!node_modules' --glob '!dist' --glob '!ui/node_modules' --glob '!ui/dist'returned no matches.\n-npm run build\n-npm --prefix ui run build\n-npm --prefix ui run test -- src/components/chat/hooks/useChatComposerState.test.ts src/components/chat-v2/processGrouping.test.ts src/components/chat-v2/MessagesPaneV2.render.test.tsx src/components/chat/view/subcomponents/MessageComponent.tool-error.test.tsx\n\nNote:npm --prefix ui run typecheckstill fails on pre-existing React type-version and unrelated TS issues; this change does not add new typecheck failures in the root build.