Extend wall slabs past their ends to close corner gaps#4
Merged
Conversation
A wall slab ran exactly from its segment start to end, so two perpendicular walls meeting at an outer corner left a t/2 x t/2 square gap. Extend every slab by half a thickness at each end; perpendicular walls then overlap in the corner square. Doorway opening offsets shift by the extension to stay aligned with the wall. A doorway authored flush with a wall's start consequently gains a left jamb -- the corner stub now sits beside it -- so the affected BoundaryWallBuilder geometry test is updated to expect that.
SilicoBen
added a commit
that referenced
this pull request
May 18, 2026
This reverts commit 66a030e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t/2 x t/2square gap. Each slab is now extended half a thickness past each end; perpendicular walls overlap in the corner square and the gap closes.BoundaryWallBuildergeometry test is updated to expect this.Test plan
dotnet test-- 129 passed.