[python] test HTTPX sync wire names#24130
Merged
wing328 merged 1 commit intoJun 26, 2026
Merged
Conversation
Member
|
just pushed 2b6b544 to master to update the samples. let's see if the CI tests pass |
tamird
force-pushed
the
upstream/python-regenerate-httpx-sync-wire-samples
branch
from
5e2b94b to
ebea6ce
Compare
tamird
changed the title
Contributor
Author
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
tamird
force-pushed
the
upstream/python-regenerate-httpx-sync-wire-samples
branch
from
ebea6ce to
2816412
Compare
tamird
changed the title
Contributor
Author
|
@wing328 this now just adds the missing unit test coverage. PTAL |
tamird
force-pushed
the
upstream/python-regenerate-httpx-sync-wire-samples
branch
from
2816412 to
627690b
Compare
Commit 2b6b544 brings the HTTPX sync generated models in line with 3a307ab. The handwritten oneOf and anyOf tests still construct payloads with sanitized Python names, so the sample jobs now fail while deserializing BasquePig. Update those tests to send and assert the exact wire names. This keeps the regression coverage aligned with the generated fields and catches future sample drift.
tamird
force-pushed
the
upstream/python-regenerate-httpx-sync-wire-samples
branch
from
627690b to
d6517f4
Compare
Contributor
Author
|
The remaining CircleCI node2 failure is unrelated to this Python-only change. It selected cpp-restsdk and exited during toolchain setup; the only reported error is apt rejecting Google's Chrome repository because public key |
Member
|
agreed circleci test failure not related to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 2b6b544f brings the HTTPX sync generated models in line with
3a307ab7. The handwritten
oneOfandanyOftests still constructpayloads with sanitized Python names, so the sample jobs now fail while
deserializing
BasquePig.Update those tests to send and assert the exact wire names. This keeps
the regression coverage aligned with the generated fields and catches
future sample drift.