[Kotlin][Spring] fix option useSpringBuiltInValidation not implemented#24115
Merged
wing328 merged 4 commits intoJun 24, 2026
Conversation
…lied' of https://github.com/tomas-pecserke/openapi-generator into tomas-pecserke-hotfix/kotlin-spring-built-in-validation-option-not-applied
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java:533">
P1: Missing `writePropertyBack(USE_SPRING_BUILT_IN_VALIDATION, useSpringBuiltInValidation)`. Without it, the flag value never reaches the Mustache template context. When the user explicitly passes `useSpringBuiltInValidation=false`, the String `"false"` left in `additionalProperties` is truthy in Mustache, so `{{^useSpringBuiltInValidation}}` incorrectly fails to render, causing `@Validated` to be skipped despite the flag being false.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #23951 with updated doc, bug fix.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes the
kotlin-springgenerator souseSpringBuiltInValidationdisables class-level@Validatedon generated controllers and interfaces whenuseBeanValidationis on. Default behavior is unchanged.KotlinSpringServerCodegen(flag, CLI switch,processOpts/writePropertyBack).api.mustacheandapiInterface.mustacheto skip the import and annotation when enabled.docs/generators/kotlin-spring.md.Written for commit bb4112b. Summary will update on new commits.