fix(kotlin-spring): fix Flow<String> and Flux<T> array return types f…#24101
Draft
Picazsoo wants to merge 1 commit into
Draft
fix(kotlin-spring): fix Flow<String> and Flux<T> array return types f…#24101Picazsoo wants to merge 1 commit into
Picazsoo wants to merge 1 commit into
Conversation
…or reactive generators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or reactive generators
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes reactive array return types in the Kotlin Spring generators to avoid broken decoding and unify API shapes. Arrays of strings now return
List<String>withsuspend(notFlow<String>), and declarative Reactor interfaces returnMono<List<T>>(notFlux<T>).Bug Fixes
kotlin-spring): for array-of-string responses, generatesuspend+List<String>to avoidStringDecoderswallowing JSON arrays in Spring WebFlux (issue 22662).spring-declarative-http-interface): array responses now useMono<{{returnContainer}}<T>>(i.e.,Mono<List<T>>), includingMono<ResponseEntity<List<T>>>when enabled; dropreactor.core.publisher.Fluximport.x-reactive-array-string-returnvendor extension and updated templates to conditionally emit the new signatures.Migration
Flow<String>toList<String>and mark methods assuspendwhere applicable.Flux<T>returns withMono<List<T>>(andMono<ResponseEntity<List<T>>>when used); update imports and tests.Written for commit 857e8b1. Summary will update on new commits.