Skip to content

[csharp][generichost] Add OnCreated to JsonConverter#24079

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
devhl-labs:devhl/add-OnCreated-to-jsonconverters
Jun 21, 2026
Merged

[csharp][generichost] Add OnCreated to JsonConverter#24079
wing328 merged 1 commit into
OpenAPITools:masterfrom
devhl-labs:devhl/add-OnCreated-to-jsonconverters

Conversation

@devhl-labs

Copy link
Copy Markdown
Contributor

Adding OnCreated to the JsonConverter so we have an appropriate place to set the date format.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

/// The format to use to serialize {{name}}
/// </summary>
public static string {{name}}Format { get; set; } = "{{{dateTimeFormat}}}";
public string {{name}}Format { get; private set; } = "{{{dateTimeFormat}}}";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users may consider this (static to non-static) a breaking change.

we may need to provide a way to fallback if users ask for it.

@wing328 wing328 added this to the 7.24.0 milestone Jun 21, 2026
@wing328 wing328 merged commit b719ee2 into OpenAPITools:master Jun 21, 2026
34 checks passed
@devhl-labs devhl-labs deleted the devhl/add-OnCreated-to-jsonconverters branch June 21, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants