[JAVA] [SPRING] Handle list of String special case in reactive generator#24078
[JAVA] [SPRING] Handle list of String special case in reactive generator#24078TMRGZ wants to merge 2 commits into
Conversation
|
The Kotlin Spring generator could need a similar fix but I am not used to code in Kotlin, feel free to add it to this PR |
|
I only reviewed on mobile so far, but do I understand correctly that you are hiding the 'now correct' behavior behind a config option and by default it will still produce the incorrect code? I would expect it to be either
As I mentioned this is based on a very quick skimming of the changes in the PR. Note: I am not in any way a maintainer of this project - just providing my proverbial 2 cents of feedback (-: |
|
Hi @Picazsoo, thanks for the feedback. Just to note, the feature flag for the fix is enabled by default and the PR is and adaptation of this other https://github.com/OpenAPITools/openapi-generator/pull/16326/changes. I guess that the fallback was created just in case someone wants to stay with the original behaviour. |
|
If no one picks it up for kotlin-spring before next week, I will see what I can do. I think that reactor is limited to spring http interface there... |
Related: #24077
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes reactive Spring return types for array of string responses by returning Mono<List> or Mono<Set> instead of Flux. Applies to
spring-bootandspring-http-interfacelibraries and aligns generated code with the OpenAPI schema.x-reactive-return-except-list-of-stringvendor extension.SpringCodegensets the extension for array responses with base typestringin reactive mode.responseType.mustacheto emitMono<ResponseEntity<List<String>>>/Mono<ResponseEntity<Set<String>>>(or withoutResponseEntity) instead ofFlux<String>.spring-bootandspring-http-interface, with and withoutuseResponseEntity, verifyingMono<List<String>>/Mono<Set<String>>signatures.Written for commit b07ba00. Summary will update on new commits.