[kotlin] Fix boolean const enum literal generation#24022
Merged
wing328 merged 1 commit intoJun 14, 2026
Merged
Conversation
Member
|
lgtm. thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23550.
This keeps Kotlin boolean enum/const values as boolean literals when rendering enum values. Before this change,
const: truecould generate a Kotlin enum entry with"true"even though the enum value type iskotlin.Boolean.I added a focused
toEnumValueassertion and a generated-output regression fixture for the reported OpenAPI 3.1 booleanconst: truecase.Tests:
./mvnw clean package./bin/generate-samples.sh ./bin/configs/*.yaml./bin/utils/export_docs_generators.shKotlin technical committee: @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l @dennisameling
Summary by cubic
Ensure Kotlin boolean const enums are generated as boolean literals, not strings. Fixes #23550.
toEnumValueto pass through values forkotlin.Boolean(likekotlin.Int/kotlin.Long).const: truewithjvm-ktorandjackson, plus a regression fixture (issue23550-boolean-const.yaml).Written for commit a9e10a1. Summary will update on new commits.