Skip to content

Add tests for pip install#23892

Merged
wing328 merged 3 commits into
masterfrom
pip-test
May 28, 2026
Merged

Add tests for pip install#23892
wing328 merged 3 commits into
masterfrom
pip-test

Conversation

@wing328

@wing328 wing328 commented May 28, 2026

Copy link
Copy Markdown
Member

a follow up pr to #23889

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add pip install -r requirements.txt to the Python Petstore samples workflow to install base deps before poetry install. This reduces CI failures and clarifies step names.

  • Refactors
    • Added "Install via pip" step before installing poetry.
    • Renamed "Install" to "Install via poetry" for clarity.

Written for commit 8e9cc4f. Summary will update on new commits.

Review in cubic

@wing328 wing328 changed the title test pip install Add tests for pip install May 28, 2026
@wing328 wing328 marked this pull request as ready for review May 28, 2026 03:53

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wing328 wing328 merged commit 8e23623 into master May 28, 2026
36 checks passed
@wing328 wing328 deleted the pip-test branch May 28, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant