static access to normalizeMediaType in typescript object serializer#20202
Conversation
…cript object serializer accessing `normalizeMediaType` should be done static in `ObjectSerializer`, as described in OpenAPITools#20201. fix applies only to the `typescript` generator.
joscha
left a comment
There was a problem hiding this comment.
ObjectSerializer is in the * import, yes? I haven't actually checked. Intent LGTM
|
@macjohnny @wing328 I'll need one of you for |
|
@macjohnny did you check |
it is in the very same file, its the class that is defined in that file |
I looked and must have scrolled past it :-/ Thank you! |
sorry for my late answer, I was out of office for lunch. that is correct. the method is a static method of this very class. thanks for your quick doing guys! |
accessing
normalizeMediaTypeshould be done static inObjectSerializer, as described in #20201.fix applies only to the
typescriptgenerator.closes #20201 if accepted as solution by maintainers.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @joscha