Demo GHAs: {minimal,test-gpu,multi-job}.yml#2
Open
ryan-williams wants to merge 14 commits into
Open
Conversation
mihasya
reviewed
Jul 22, 2025
jder
approved these changes
Jul 22, 2025
jder
left a comment
jder
left a comment
Member
There was a problem hiding this comment.
Didn't read super carefully given it's a demo but this looks awesome!
Will revert to `main` or `v1` before merging (once Open-Athena/ec2#1 lands)
alxmrs
approved these changes
Jul 28, 2025
alxmrs
left a comment
alxmrs
left a comment
Member
There was a problem hiding this comment.
Demo looks good! I added one more idea for a think to demonstrate (another common use case).
|
|
||
| [Open-Athena/ec2@dev]: https://github.com/Open-Athena/ec2/tree/dev | ||
| [minimal.yml]: .github/workflows/minimal.yml | ||
| [test-gpu.yml]: .github/workflows/test-gpu.yml |
Member
There was a problem hiding this comment.
🐑 Idea: have a demo workflow that illustrates how to run several different type of EC2 VMs in a test matrix? This could be useful, for example, to test running on ARM vs x86 vs Windows vs ....
ryan-williams
changed the title
{minimal,test-gpu}.yml{minimal,test-gpu,multi-job}.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
userdata/key_nameinputs, single-instance convenience outputs ec2-gha#1Example runs: