Feat: add client version tracking and callback to TaskControllerServer#693
Merged
ad3154 merged 3 commits intoJun 6, 2026
Merged
Conversation
Add automatic version detection and callback mechanism for Task Controller server to track connected client versions. Changes: - Add on_client_version_received() virtual callback for applications - Add get_client_version() getter to retrieve stored client version - Add request_client_version() method for proactive version queries - Automatically request version when new client detected via WorkingSetMaster - Add INFO/DEBUG logging for version exchange events - Add comprehensive unit tests for version tracking functionality The callback fires when client version info is received, supporting both V3 (SecondEditionDraft) and V4+ (SecondPublishedEdition). Version exchange is optional in V3 but automatic in the server implementation.
Member
|
This looks OK to me. If you can update the example to fix the pipeline failure, then I would be OK with approving it. |
ad3154
added
enhancement
Contributor
Author
|
I tested this with a couple equipments this week and seems to work with all of them . |
ad3154
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automatic version detection and callback mechanism for Task Controller server to track connected client versions.
Changes:
The callback fires when client version info is received, supporting both V3 (SecondEditionDraft) and V4+ (SecondPublishedEdition). Version exchange is optional in V3 but automatic in the server implementation.