Skip to content

Clang 23 and deployment build fixes - #758

Merged
mcarans merged 3 commits into
OoliteProject:masterfrom
mcarans:clang_23
Oct 9, 2026
Merged

Clang 23 and deployment build fixes#758
mcarans merged 3 commits into
OoliteProject:masterfrom
mcarans:clang_23

Conversation

@mcarans

@mcarans mcarans commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update GNUstep library versions to fix Clang 23 #759
Also fix GNUstep libraries being checked out and built in wrong folder (2 levels down from root)
Fix deployment build issue #757

@mcarans

mcarans commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sigh...will have to wait for this NSIS fix to drop: msys2/MINGW-packages#32208

@mcarans
mcarans marked this pull request as draft October 6, 2026 23:58
@mcarans

mcarans commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

MSYS2 nsis fixed package is awaiting release: https://packages.msys2.org/queue

@mcarans
mcarans marked this pull request as ready for review October 8, 2026 07:40
@mcarans

mcarans commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

@oocube @phkb please let me know if any issues with deployment build

@oocube

oocube commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Looking at https://github.com/OoliteProject/oolite/actions/runs/37548702252 there are no linux related artefacts, yet the linux builds ran successfully. What happened?

@mcarans

mcarans commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@oocube I reran failed Windows jobs after MSYS2 released a new NSIS package, so only they got created on that page. I restarted the build for all jobs so all artifacts have now been created: https://github.com/OoliteProject/oolite/actions/runs/37548702252?pr=758

@mcarans

mcarans commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I downloaded and tested AppImage and Flatpak and both seem ok (Flatpak uses deployment).

@oocube

oocube commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

I downloaded and tested AppImage and Flatpak and both seem ok (Flatpak uses deployment).

I tested Oolite-1.93.1-PullRequest758.3156-dev-x86_64.AppImage and it seems running fine.

@mcarans
mcarans merged commit 574ca84 into OoliteProject:master Oct 9, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oocube oocube oocube approved these changes
@phkb phkb Awaiting requested review from phkb phkb is a code owner
@mwerle mwerle Awaiting requested review from mwerle mwerle is a code owner
@Kaks Kaks Awaiting requested review from Kaks Kaks is a code owner
@AnotherCommander AnotherCommander Awaiting requested review from AnotherCommander AnotherCommander is a code owner
@ericwalch ericwalch Awaiting requested review from ericwalch ericwalch is a code owner
@dsalt dsalt Awaiting requested review from dsalt dsalt is a code owner
@KonstantinosSykas KonstantinosSykas Awaiting requested review from KonstantinosSykas KonstantinosSykas is a code owner
@kanthoney kanthoney Awaiting requested review from kanthoney kanthoney is a code owner
@jobi-wan jobi-wan Awaiting requested review from jobi-wan jobi-wan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcarans @oocube