fix: [SDK-5304] reject null and empty identity strings instead of crashing

[abdulraqeeb33]

Description

One Line Summary

Return from React Native identity string APIs when the value is null or empty instead of crashing Kotlin non-null String parameters.

Details

Motivation

Fixes SDK-5304. JS null reaches Kotlin OneSignal.login(externalId: String) (and the same class of APIs: addEmail, initialize(appId)), which throws IllegalArgumentException: Parameter specified as non-null is null. The TurboModule method is void and uncaught, so the host process dies.

Empty string does not NPE, but login("") is not a valid user id. Rejected in the same helper.

Other SDKs: SDK-5309.

Scope

isNonEmptyString in JS (null, undefined, empty). Used by login, initialize, email/sms/alias/language, tags, and triggers. Native login also returns on null/nil or empty. addTrigger now returns after the invalid-input log instead of still calling native. Public TS types stay string.

Testing

Unit testing

src/index.test.ts and src/helpers.test.ts: 289 tests passed. Covers login/initialize/addEmail null and empty, helper table, and addTrigger no longer calling native.

Manual testing

Not run on a device. The crash is a null argument at the bridge. Unit coverage is the JS helper. Native login guards match null/empty.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

[nan-li]

We have login(externalId: string) defined as string instead of optional string in the API:

react-native-onesignal/src/index.ts

Line 122 in 11cab78

export function login(externalId: string) {

Maybe we can do the check there instead of at both bridges, like we do for addTag where we check:

      if (!key || value === undefined || value === null) {
        console.error('OneSignal: addTag: must include a key and a value');
        return;
      }

Are there other methods where devs are submitting invalid inputs that can crash?

[abdulraqeeb33]

We have login(externalId: string) defined as string instead of optional string in the API:

react-native-onesignal/src/index.ts

Line 122 in 11cab78

export function login(externalId: string) {

Maybe we can do the check there instead of at both bridges, like we do for addTag where we check:

      if (!key || value === undefined || value === null) {
        console.error('OneSignal: addTag: must include a key and a value');
        return;
      }

Are there other methods where devs are submitting invalid inputs that can crash?

Good cal @nan-li - updated it in other methods as well. please check it out.

[fadi-george]

can just be !appId , similar in other places

[fadi-george]

id make the empty string changes a separate ticket and get agreement on changing for all sdks