test: [SDK-5340] cover FID exception-to-status mapping - #2763
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff). Changed Files Coverage✅ No main-source changes to gateNo Kotlin/Java changes in the diff. |
abdulraqeeb33
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add unit tests proving the FID registration path keeps the existing IOException to subscription status mapping.
Details
Motivation
Replaces an unreliable manual bug-bash case with direct unit coverage. When Firebase Installation ID registration fails with an
IOException,PushRegistratorAbstractGoogleshould still map it to-9,-29, or-11and not collapse it to-34.Scope
Tests only, no production behavior change.
PushRegistratorFCMTestscases driveregisterForPush()with a failing FIDregister()task:IOException("SERVICE_NOT_AVAILABLE")maps to-9after 3 attemptsIOException("AUTHENTICATION_FAILED")maps to-29after 3 attemptsIOExceptionmaps to-11after 1 attempt-34IOExceptionfrom the installation ID lookup maps to-11, not-34.runTestso the retry backoff delays run in virtual time, and addkotlinx-coroutines-testto the notifications test dependencies (same version as core).Testing
Unit testing
./gradlew :OneSignal:notifications:testReleaseUnitTest,spotlessCheck, anddetektall pass.-34when theIOExceptionrethrow inFCMTokenProvider.retrieveInstallationIdis removed.Manual testing
Not needed, tests only.
Affected code checklist
Checklist
Overview
Testing
Final pass