Skip to content

Remove Unmatched Stop Locations metric from dashboard scope#110

Merged
0xaboomar merged 1 commit into
mainfrom
remove-unmatched-stop-locations-metric
Jun 10, 2026
Merged

Remove Unmatched Stop Locations metric from dashboard scope#110
0xaboomar merged 1 commit into
mainfrom
remove-unmatched-stop-locations-metric

Conversation

@0xaboomar

@0xaboomar 0xaboomar commented Jun 10, 2026

Copy link
Copy Markdown
Member

Removes the Unmatched Stop Locations visualization in preparation for surfacing this data through dedicated investigation and drill-down workflows.

Summary by CodeRabbit

  • Updates
    • Removed a metric panel from the Watchdog Metrics Dashboard for improved dashboard clarity and performance.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33c21888-98a4-481d-ad64-f05310f8e487

📥 Commits

Reviewing files that changed from the base of the PR and between c0e3251 and 7990a47.

📒 Files selected for processing (1)
  • grafana/dashboards/watchdog_metrics_dashboard.json
💤 Files with no reviewable changes (1)
  • grafana/dashboards/watchdog_metrics_dashboard.json

📝 Walkthrough

Walkthrough

The Grafana Watchdog Metrics Dashboard was modified to remove the "6.2 Unmatched Stop Locations" panel (ID 602) and its associated Prometheus query. Panel 601 ("6.1 Unmatched Stop Clusters") now concludes the panels array. The resulting JSON exhibits structural irregularities with numeric literals unexpectedly present within the panel 601 definition.

Changes

Watchdog Dashboard Panel Removal

Layer / File(s) Summary
Remove unmatched stop locations panel
grafana/dashboards/watchdog_metrics_dashboard.json
Panel 602 ("6.2 Unmatched Stop Locations") and its Prometheus query (oba_unmatched_stop_location) are deleted. Panel 601 becomes the final dashboard panel. Lines 534–537 show unexpected numeric literals within the panel 601 object, indicating potential JSON structure corruption.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the 'Unmatched Stop Locations' metric visualization from the dashboard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-unmatched-stop-locations-metric

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xaboomar 0xaboomar merged commit e47c0ce into main Jun 10, 2026
3 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 49.71% (+0.1%) from 49.604% — remove-unmatched-stop-locations-metric into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants