Skip to content

Cleanup: small-exhaust sweep from the 2026-07-16 debt review#1915

Merged
bmander merged 1 commit into
mainfrom
cleanup/small-exhaust-2026-07-16
Jul 16, 2026
Merged

Cleanup: small-exhaust sweep from the 2026-07-16 debt review#1915
bmander merged 1 commit into
mainfrom
cleanup/small-exhaust-2026-07-16

Conversation

@bmander

@bmander bmander commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Mechanical, behavior-neutral cleanup of the "exhaust" left by the map-focus sprint (#1865/#1892/#1893) and the dependency-bump wave. This is the batch of small quick-wins from the 2026-07-16 debt review; the substantive findings are filed separately as #1901#1912.

No functional change. Verified: obaGoogle + obaMaplibre Kotlin compile clean under -PwarningsAsErrors=true, and FocusedTripRepositoryTest passes.

Docs / comment drift

  • CLAUDE.md: Kotlin version parenthetical 2.3.202.4.10.
  • libs.versions.toml: drop the stale "kotlin-stdlib-jdk7 pins to this" clause; correct the KSP comment — KSP2 is versioned independently of Kotlin (plain semver), not the old kotlinVersion-kspVersion format.
  • build.gradle.kts: drop the DataStore "1.0.0 was the minSdk-21 pin / adopt a newer one as a follow-up" comment — that bump (to 1.2.1) already landed.
  • Remove orphaned "trip-stop dots" references in both renderers' class docs and the clearStatic() / info-window comments (TripStopBitmaps.kt was deleted in Add adjacency-aware stop and route focus to the map #1865; stops are now reconciled in place).
  • MaterialSymbols: document the Symbols source axes (24dp / weight 400 / grade 0 / outlined) so the hand-transcribed paths can be regenerated or verified, and steer new icons toward baseline_*_24.xml drawables.
  • MapRenderState: point the two MapLibre route-badge deferral comments at the new tracking issue MapLibre: implement the adjacency route-badge layer (parity with Google, #1827) #1913.

Dead code / dedup

  • Delete the test-only FocusedTripStops.stopIds convenience property (production code uses stopIdsByTripId directly); inline the flatten into its two test assertions.
  • Hoist the duplicated Web-Mercator constant (156543.033…) into a single shared METERS_PER_PIXEL_AT_EQUATOR_ZOOM_ZERO in map/render/GeoMath.kt. GoogleMapRenderer now uses it instead of an inlined, less-precise literal (156543.03392).

Frozen dependencies

  • Remove firebase-core 21.1.1 — a discontinued empty umbrella artifact; firebase-analytics is already a direct dependency.
  • Remove kotlin-stdlib-jdk7 — merged into kotlin-stdlib since Kotlin 1.8; the Kotlin Gradle plugin adds the stdlib automatically.

Deliberately left out of this PR

These appeared in the review's "small exhaust" list but are secretly medium-effort or behavior-touching, so they stay as their own follow-ups rather than riding in a mechanical cleanup:

🤖 Generated with Claude Code

Mechanical, behavior-neutral cleanup of the "exhaust" left by the map-focus
sprint and the dependency-bump wave. No functional change.

Docs / comment drift:
- CLAUDE.md: Kotlin version parenthetical 2.3.20 -> 2.4.10.
- libs.versions.toml: drop the stale "kotlin-stdlib-jdk7 pins to this" clause;
  correct the KSP comment (KSP2 is versioned independently of Kotlin, not the
  old kotlinVersion-kspVersion format).
- build.gradle.kts: drop the DataStore "1.0.0 minSdk-21 pin / follow-up" comment
  (the follow-up bump to 1.2.1 already landed).
- Remove orphaned "trip-stop dots" references in both renderers' class docs and
  clearStatic()/info-window comments (TripStopBitmaps was deleted in #1865).
- MaterialSymbols: document the Symbols source axes (24dp/400/grade 0/outlined)
  so paths can be regenerated, and steer new icons to baseline_*_24.xml drawables.
- MapRenderState: point the MapLibre route-badge deferral comments at #1913.

Dead code / dedup:
- Delete the test-only FocusedTripStops.stopIds convenience property; inline the
  flatten into its two test assertions.
- Hoist the duplicated Web-Mercator constant (156543.033...) into a single shared
  METERS_PER_PIXEL_AT_EQUATOR_ZOOM_ZERO in map/render/GeoMath.kt; GoogleMapRenderer
  now uses it instead of an inlined, less-precise literal.

Frozen dependencies:
- Remove firebase-core 21.1.1 (discontinued empty umbrella artifact; firebase-analytics
  is already a direct dependency).
- Remove kotlin-stdlib-jdk7 (merged into kotlin-stdlib since Kotlin 1.8; the Kotlin
  Gradle plugin adds stdlib automatically).

Verified: obaGoogle + obaMaplibre Kotlin compile clean under -PwarningsAsErrors=true;
FocusedTripRepositoryTest passes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@bmander
bmander merged commit dd8923f into main Jul 16, 2026
2 checks passed
@bmander
bmander deleted the cleanup/small-exhaust-2026-07-16 branch July 16, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant