fix: sort schedule-for-stop times by departure time

[ARCoder181105]

Description

This PR corrects the sorting behavior of the schedule-for-stop API endpoint. Previously, fixed-schedule stop times within direction groups were being sorted sequentially by arrival_time. This has been updated to align with the specification, ensuring they are strictly sorted by departure_time.

Changes Made

• SQL Queries: Updated GetScheduleForStop and GetScheduleForStopOnDate in gtfsdb/query.sql to use ORDER BY r.id, st.departure_time.
• Generated Code: Ran make models to regenerate query.sql.go and align it with the updated SQL.
• Unit Tests: Enhanced TestScheduleForStopQueryValidation in internal/restapi/schedule_for_stop_handler_test.go with an explicit assertion loop to verify that stop times are strictly returned in ascending order of departureTime.

Acceptance Criteria Verified

• Stop times within a StopRouteDirectionSchedule are sorted strictly by departure_time ascending.
• Unit tests verify this sorting behavior explicitly.

Closes #1033

Summary by CodeRabbit

• Bug Fixes

  • Updated schedule query results to order by departure time instead of arrival time.

• Tests

  • Added validation that schedule results are correctly sorted by departure time.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 80eb2f59-b4d0-4434-849b-798a07227f71

📥 Commits

Reviewing files that changed from the base of the PR and between e99ee63 and 0b31450.

📒 Files selected for processing (3)

• gtfsdb/query.sql
• gtfsdb/query.sql.go
• internal/restapi/schedule_for_stop_handler_test.go

---

📝 Walkthrough

Walkthrough

The PR fixes the schedule stop times sorting order by updating both SQL queries and their Go-generated equivalents to sort by departure_time instead of arrival_time, and adds validation tests to confirm the fix works correctly.

Changes

Schedule Sort Order Fix

Layer / File(s)	Summary
Schedule query sort order fix gtfsdb/query.sql, gtfsdb/query.sql.go	The GetScheduleForStop and GetScheduleForStopOnDate queries are updated to order by r.id, st.departure_time instead of r.id, st.arrival_time. Both the SQL source and generated Go code reflect this change.
Departure time sorting validation internal/restapi/schedule_for_stop_handler_test.go	TestScheduleForStopQueryValidation validates that stopTimes within the returned schedule are sorted in ascending order by departureTime through adjacent-pair comparisons.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• burma-shave
• aaronbrethorst
• Ahmedhossamdev

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: modifying the sort order of schedule-for-stop times from arrival_time to departure_time, which is the core fix addressed in the PR.
Linked Issues check	✅ Passed	The PR fully addresses issue #1033: SQL queries updated to sort by departure_time, Go code regenerated, and unit tests enhanced to verify departure_time sorting.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to issue #1033: SQL query ordering fixes, code regeneration, and test enhancements for departure_time sorting.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ARCoder181105]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[ARCoder181105]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.