Skip to content

Feat: add typing to the package - #280

Draft
elliot-100 wants to merge 5 commits into
Olen:mainfrom
elliot-100:mypy-and-hints-2
Draft

elliot-100 wants to merge 5 commits into
Olen:mainfrom
elliot-100:mypy-and-hints-2

Conversation

@elliot-100

@elliot-100 elliot-100 commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Needs PR #276 merged first.

This PR:

  • Adds mypy as a development dependency with a fairly lax initial baseline configuration
  • Also extends ruff ruleset to require type hints (except for args and **kwargs which I will come back to)
  • Adds type hints and type: ignore[] comments to get to that baseline
  • Enforces that baseline in CI (also cleans up comments on other checks)
  • Documents how to run ruff and mypy checks in development
  • Marks the package as typed so consumers can type check it in their applications

@elliot-100 elliot-100 linked an issue Oct 12, 2026 that may be closed by this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type-checking and enforce hints in CI

1 participant