Add update_member and get_members_xlsx methods

[alistair0adams]

Added two methods

1. update_member() which will POST updated member data back to Spond
2. get_members_xlsx() which will download the Excel sheet that can be manually downloaded from the Spond website. This can easily then be converted into a Dataframe.

[elliot-100]

Thanks for this @alistair0adams .

Are you OK to add the missing return annotation? Should be JSONDict.

[alistair0adams]

JSONDict annotation added

[elliot-100]

Sorry @alistair0adams have been on other projects. Will try to test in next 1-2 weeks.

[Olen]

Thanks @alistair0adams — preparing a 1.2.1 release sweep and would love to bring these methods in. Before merging, this PR needs a quick refresh:

1. Rebase against main — the branch is currently flagged as conflicting after recent merges.
2. Docstring fixups:
   • update_member: "Updated memberi" typo (extra i).
   • update_member: references get_personb() — should be get_person().
3. Add a test for at least one of the two methods. The existing tests/test_spond.py::TestExportMethod::test_get_export is a close shape for get_members_xlsx and easy to adapt; update_member can follow test_change_response's mocking pattern.

If you're short on time and want to land just the cleanup + rebase, I'm happy to take #197 over by pushing to your branch (or open a follow-up PR that picks your commit). Let me know what works best.

[alistair0adams]

Sorry for the non resposonse earlier. I think we're all suffering working on other things. This is a heads up that I have done the rebase, written two tests, fixed the typos, but have a few test to do before saying it's ready to have another go at at PR. Please be patient, lots of things here that I had to learn that are not part of my daily life.

[alistair0adams]

Looks like this is ready to go. It seems to have passed all the test so hoping I've got everything right.

[Copilot]

🟡 Changes recommended

The payments API is outside the stated scope, lacks tests, has an incorrect return contract, and the changed Python files fail repository formatting conventions.

4 open findings

• Fix Ruff violations across changed Python files · New
• Remove out-of-scope payments feature or update PR scope · New
• Replace “wont” with “want” · New
• Fix typo in example comment · New

What changed in this PR

Adds member update/export APIs, plus an additional received-payments API.

Changes:

• Adds member updating and XLSX export methods with tests.
• Adds received-payment retrieval and caching.
• Documents APIs and provides usage examples.

File	Description
spond/​spond.py	Implements the three API methods.
tests/​test_spond.py	Tests member updating and XLSX export.
README.md	Documents the new methods.
examples/​update_member.py	Demonstrates updating member fields.
examples/​payments.py	Demonstrates exporting payments.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[elliot-100]

@alistair0adams not sure if you are familiar with ruff?
You should be able to resolve most of the issues reported with:

poetry run ruff format
poetry run ruff check --fix

(We should document this in contribution guidelines).

Have to say, adding new (payments) features to an in-progress PR isn't a good idea. Can I suggest, to get this done, just remove them to a future PR?

[alistair0adams]

Thanks @elliot-100. I'd used ruff when it complained earlier but not with the format option. I've taken out the payments feature. It looks clean to me but as I've found out looks can be deceiving.

[Olen]

Your effort is highly appreciated.