fix(tui): highlight Containerfile, Dockerfile.*, and shell dotfiles - #433
amandeavor wants to merge 1 commit into
Conversation
languageForPath missed Podman Containerfiles, Dockerfile.dev-style variants, GNUmakefile, Vagrantfile, and common shell rc files. Add exact-name mappings, a Dockerfile.*/Containerfile.* prefix rule, and dedicated highlight tests. Closes Observal#427
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds syntax-highlighting mappings for Containerfile, GNUmakefile, Vagrantfile, and common shell startup files. It also recognizes Dockerfile and Containerfile names with suffixes. Tests cover the new mappings and existing path-resolution behavior. ChangesSyntax highlighting filename recognition
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The filename-highlighting change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description summarizes the change, links issue Resolution Update the description to use the required headings. Add the purpose, implementation approach and compatibility or security impact, complete testing details including all relevant checks and unverifiable checks, complete the checklist, and provide the AI assistance information.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
languageForPathnow recognizes:Containerfile/Containerfile.*(dockerfile)Dockerfile.*variants such asDockerfile.devGNUmakefile,Vagrantfile.bashrc,.zshrc,.bash_profile,.profileAdds
packages/tui/test/highlight.test.tscovering new names, existing extensions, mixed case, Windows paths, and unknown names.Closes #427
Test plan
pnpm --filter @axl/tui exec node --test test/highlight.test.ts(5 pass)Summary by CodeRabbit