Added nullptr checks for mRenderManager in OSVRCustomPresent, OSVRCustomPresentD3D11, and OSVRCustomPresentOpenGL.#143
Open
JeroMiya wants to merge 1 commit into
Open
Added nullptr checks for mRenderManager in OSVRCustomPresent, OSVRCustomPresentD3D11, and OSVRCustomPresentOpenGL.#143JeroMiya wants to merge 1 commit into
JeroMiya wants to merge 1 commit into
Conversation
…tomPresentD3D11, and OSVRCustomPresentOpenGL.
| check(rc == OSVR_RETURN_SUCCESS); | ||
| if (rc != OSVR_RETURN_SUCCESS) | ||
| { | ||
| UE_LOG(FOSVRCustomPresentLog, Warning, |
Contributor
There was a problem hiding this comment.
This and the other messages will appear each time a frame tries to render, right? That's a lot of messages.
Contributor
Author
There was a problem hiding this comment.
I could probably limit it, but if they're getting it every frame something more serious is wrong instead of just a transient error.
| if (!mRenderManager) | ||
| { | ||
| UE_LOG(FOSVRCustomPresentLog, Warning, | ||
| TEXT("FOpenGLCustomPresent::FinishRendering() - mRenderManager is null. Should be non-null at this point.")); |
Contributor
There was a problem hiding this comment.
Maybe make this message say that rendering won't work and then remove the later messages but keep the checks?
Contributor
|
Looks like it will work. Added comments about how to potentially reduce log-file messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #140