[jekuaitk]

#329

Introduces three new nemid elements:

First name, middle name and last name.

Important

Is dependent on OS2web/os2web_datalookup#31 and should force an upgrade to the release of https://github.com/OS2web/os2web_datalookup in which that PR in contained.

[rimi-itk]

Looks good.

[ds-bellcom]

@OS2Forms/koordinationsgruppe vi estimerer 3 timer til review af denne - inkl. OS2web/os2web_datalookup#31, som hænger sammen med denne, men I et andet repo. Vil I godkende?

[stankut]

no comments regarding the code.

Small comment about the approach though:
but i would finalize merging OS2web/os2web_datalookup#31 first, create another version for os2web_datalookup, and then bump os2web_datalookup version dependency in the composer.json

in this way we are eliminating a risk of using os2web_datalookup version where new fields have not been added yet.

[ds-bellcom]

Please wait to merge this PR until the Drupal 11 release is out.

[ds-bellcom]

@jekuaitk this PR may now be merged to develop-branch.

[jekuaitk]

no comments regarding the code.

Small comment about the approach though: but i would finalize merging OS2web/os2web_datalookup#31 first, create another version for os2web_datalookup, and then bump os2web_datalookup version dependency in the composer.json

in this way we are eliminating a risk of using os2web_datalookup version where new fields have not been added yet.

Bumped os2web_datalookup version!