You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
WebformInheritTask loses edits on all but the latest wizard page #336
When a WebformInherit-task (os2forms_forloeb) inherits a submission into a multi-page wizard, edits made on any page other than the final one are silently discarded on submit.
Reproduce
Create a Maestro flow with a WebformInherit-task that inherits an earlier submission.
Use a multi-page (wizard) webform with editable fields on at least two pages.
Open the inherit task — fields prefill correctly from the inherited submission.
Edit a field on page 1 and a field on page 2.
Submit.
Go the submission and observe that only edits on the final page persists. Data on any other page reverts to the inherited value.
Cause
MaestroWebformInheritTask::webformSubmissionFormAlter() runs on hook_webform_submission_form_alter, which fires on every form build. Any time it runs it sets each field's value to the inherited value. As a result, page transitions also override previous page data.
Webform core guards its own pre-population against exactly this in WebformSubmissionForm::buildForm().
Fix
Add equivalent guard to the WebformInherit-task.
Test
Same as reproduce but with different result:
Create a Maestro flow with a WebformInherit-task that inherits an earlier submission.
Use a multi-page (wizard) webform with editable fields on at least two pages.
Open the inherit task — fields prefill correctly from the inherited submission.
Edit a field on page 1 and a field on page 2.
Submit.
Go the submission and observe that all edited data persists.
@ds-bellcom This is superseded by #352. The change in the PR relating to that issue will inadvertently solve this issue!
@jekuaitk eller @gBarlach vil I ikke lukke de issues og evt. PR, som ikke længere er aktuelle, således at vi kun har de issues der stadig er aktuelle tilbage?
Activity
ds-bellcom commentedon Aug 25, 2026
@OS2Forms/koordinationsgruppe som skrevet inde på #337, så estimerer vi 1 time til review på denne opgave.
jekuaitk commentedon Sep 15, 2026
@ds-bellcom This is superseded by #352. The change in the PR relating to that issue will inadvertently solve this issue!
ds-bellcom commentedon Sep 15, 2026
@jekuaitk eller @gBarlach vil I ikke lukke de issues og evt. PR, som ikke længere er aktuelle, således at vi kun har de issues der stadig er aktuelle tilbage?