Skip to content

changed thermoFile directory#73

Merged
colemanjs merged 1 commit into
mainfrom
fixup-thermopath
Sep 17, 2025
Merged

changed thermoFile directory#73
colemanjs merged 1 commit into
mainfrom
fixup-thermopath

Conversation

@colemanjs

Copy link
Copy Markdown
Collaborator

Set to the constant directory in the global case name to work with '-case' flag

@colemanjs colemanjs requested a review from gknapp1 September 16, 2025 20:39
@colemanjs colemanjs self-assigned this Sep 16, 2025
@gknapp1

gknapp1 commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

Looking at the core OpenFOAM solvers, doesn't this already get handled by #include "setRootCase.H" in the main additiveFoam.C?

If not, it seems like you would have to update the paths in more places.

@gknapp1 gknapp1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did check, and it doesn't break anything with Myna integration.

@colemanjs

Copy link
Copy Markdown
Collaborator Author

Looking at the core OpenFOAM solvers, doesn't this already get handled by #include "setRootCase.H" in the main additiveFoam.C?

If not, it seems like you would have to update the paths in more places.

IOObjects in OpenFOAM have the appropriate paths set in setRootCase.H, but we have to explicitly defined the paths for files to support the -case option of OpenFOAM executables.

@colemanjs colemanjs merged commit 5e4794d into main Sep 17, 2025
1 check passed
@colemanjs colemanjs deleted the fixup-thermopath branch September 30, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants